Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ajout du formulaire de contact dans l'assistant #1190

Merged
merged 8 commits into from
Jan 21, 2025
Merged

Ajout du formulaire de contact dans l'assistant #1190

merged 8 commits into from
Jan 21, 2025

Conversation

fabienheureux
Copy link
Member

@fabienheureux fabienheureux commented Jan 8, 2025 •
edited
Loading

Description succincte du problème résolu

https://www.notion.so/accelerateur-transition-ecologique-ademe/Envoi-d-un-message-il-manque-le-formulaire-de-contact-1536523d57d780d9875fd5b2c900825d?pvs=4

Ajout d'un formulaire de contact au clic sur la modal

  • Envoi de la soumission dans Notion
  • On ne stocke / log rien côté Django

Type de changement :

  • Bug fix
  • Nouvelle fonctionnalité
  • Mise à jour de données / DAG
  • Les changements nécessitent une mise à jour de documentation
  • Refactoring de code (explication à retrouver dans la description)

Auto-review

Les trucs à faire avant de demander une review :

  • J'ai bien relu mon code
  • La CI passe bien
  • En cas d'ajout de variable d'environnement, j'ai bien mis à jour le .env.template
  • J'ai ajouté des tests qui couvrent le nouveau code

Comment tester

En local / staging :

Développement local

  • Mettre à jour les variables d'environnement

Déploiement

  • Mettre à jour les variables d'environnement

@fabienheureux fabienheureux marked this pull request as ready for review January 9, 2025 13:40
@fabienheureux fabienheureux requested a review from a team as a code owner January 9, 2025 13:40
@fabienheureux fabienheureux requested review from kolok and maxcorbeau and removed request for a team January 9, 2025 13:40
maxcorbeau
maxcorbeau approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@maxcorbeau maxcorbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tout me parait bien.

kolok
kolok reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@kolok kolok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai fait quelques remarques :)

qfdmd/views.py Outdated Show resolved Hide resolved
qfdmd/urls.py Show resolved Hide resolved
templates/forms/contact.html Show resolved Hide resolved
kolok
kolok approved these changes Jan 13, 2025
View reviewed changes
templates/forms/contact.html Show resolved Hide resolved
@fabienheureux fabienheureux force-pushed the contact-form-assistant branch 6 times, most recently from f6d6012 to 8684808 Compare January 21, 2025 10:04
@fabienheureux fabienheureux force-pushed the contact-form-assistant branch from 46a2851 to 824b2dc Compare January 21, 2025 10:48
kolok
kolok approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@kolok kolok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Une petite remarque

core/notion.py Outdated Show resolved Hide resolved
@fabienheureux @kolok
Update core/notion.py
e06bf1e 
Co-authored-by: Nicolas Oudard <[email protected]>
@fabienheureux fabienheureux enabled auto-merge (squash) January 21, 2025 10:57
@fabienheureux fabienheureux merged commit 856efc2 into main Jan 21, 2025
11 checks passed
@fabienheureux fabienheureux deleted the contact-form-assistant branch January 21, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxcorbeau maxcorbeau maxcorbeau approved these changes

@kolok kolok kolok approved these changes

Assignees

@kolok kolok

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabienheureux @kolok @maxcorbeau